What's wrong with this gmail script contacts importer for Drupal?
Drupal has a gmail contacts importer module which has been about the same since about 7 months. I have no cuts to debug the problem, the maintainer has disappeared and I think this is an important part of the job. So I turn to StackOverflow for help.
Problem. When you fill in your credentials and tell the script to get your contacts back, it pulls at 25 by default. This works fine.
When you are told to search for more contacts by changing the url that you request from this:
http://www.google.com/m8/feeds/contacts/default/thin
:
http://www.google.com/m8/feeds/contacts/default/thin?max-results=1000
You get the following fatal error:
Fatal error: Calling member function
getAttribute()
for non-object atpath/to/site/sites/all/modules/dcl_importer/scripts/importGData.class.php
on line 97
Here's the script:
class GDataMailer {
static $url_ClientLogin = 'https://www.google.com/accounts/ClientLogin';
static $url_Feed = 'http://www.google.com/m8/feeds/contacts/default/thin?max-results=65535';
function newCurlSession($URL, $auth = null) {
$curl = curl_init();
$opts = array(
CURLOPT_URL => $URL,
CURLOPT_REFERER => '',
CURLOPT_SSL_VERIFYPEER => false,
CURLOPT_SSL_VERIFYHOST => true,
CURLOPT_RETURNTRANSFER => true,
CURLOPT_FOLLOWLOCATION => true,
);
if (null != $auth) {
$opts[CURLOPT_HTTPHEADER] = array(
'Authorization: GoogleLogin auth='.$auth,
);
}
curl_setopt_array($curl, $opts);
return $curl;
}
function useCurlForPost($curl, $params) {
curl_setopt($curl, CURLOPT_POST, true);
curl_setopt($curl, CURLOPT_POSTFIELDS, $params);
return $curl;
}
function getAuthToken($login, $password) {
$curl = $this->useCurlForPost($this->newCurlSession(self::$url_ClientLogin), array(
'accountType' => 'HOSTED_OR_GOOGLE',
'Email' => $login,
'Passwd' => $password,
'service' => 'cp',
'source' => 'Drupal-Contact-Importer',
));
$resp = curl_exec($curl);
// Look for the important stuff:
preg_match_all('/Auth=([^\s]*)/si', $resp, $matches);
if (isset($matches[1][0])) {
return $matches[1][0];
} else {
return false;
}
}
function getAddressbook($login, $password) {
// check if username and password was given:
if ((isset($login) && trim($login)=="") || (isset($password) && trim($password)==""))
{
$args = func_get_args();
drupal_set_message('Incorrect login information given: '.print_r($args, true), 'error');
return false;
}
// Get the GData auth token:
$auth = $this->getAuthToken($login, $password);
if (false === $auth) {
drupal_set_message('Login failed', 'error');
return false;
}
$curl = $this->newCurlSession(self::$url_Feed, $auth);
$data = curl_exec($curl);
$doc = new DOMDocument();
$doc->loadXML($data);
$path = new DOMXPath($doc);
$path->registerNamespace('a', 'http://www.w3.org/2005/Atom');
$path->registerNamespace('gd', 'http://schemas.google.com/g/2005');
$nodes = $path->query('//a:entry');
$num = $nodes->length;
$contacts = array();
for ($x = 0; $x < $num; $x++) {
$entry = $nodes->item($x);
$tnodes = $path->query('a:title', $entry);
$nnode = $tnodes->item(0);
$name = $nnode->textContent;
$enodes = $path->query('gd:email', $entry);
$mnode = $enodes->item(0);
$email = $mnode->getAttribute('address');
// NOTE: Keep in mind that $mnode->getAttribute('rel') tells you what kind of email it is.
// NOTE: Also remember that there can be multiple emails per entry!
if (empty($name)) {
$contacts[] = $email;
} else {
$contacts[$name] = $email;
}
}
return $contacts;
}
}
Line 97 is the line $email = $mnode->getAttribute('address');
near the end.
What can I change here so that I don't get this error again and make this work for the Drupal community? I want the entire contact list to be more than just 25. I figure if I sent a number high enough it would be close enough to get through.
a source to share
Without testing it directly, I would try to replace lines 96 - 104 with the following:
$mnode = $enodes->item(0);
if (isset($mnode) && is_object($mnode)) {
$email = $mnode->getAttribute('address');
// NOTE: Keep in mind that $mnode->getAttribute('rel') tells you what kind of email it is.
// NOTE: Also remember that there can be multiple emails per entry!
if (!empty($email)) {
if (empty($name)) {
$contacts[] = $email;
} else {
$contacts[$name] = $email;
}
}
}
gd: email is optional according to Google Data API . This is optional in the Gmail implementation. The module you are using assumes it exists and fails when it doesn't.
Multiple email addresses for each contact are left unprocessed as per note NOTE: comment.
a source to share