Should I post a patch against 2-3-stable or master

I am trying to find a way to contribute to rails. I thought I should check if this patch works https://rails.lighthouseapp.com/projects/8994/tickets/4154-expires_now-broken .

I was able to verify the problem. The problem still exists in 2.3.5 and in 2-3-stable rails.

I have not been able to apply my patch on a 2-3 resilient rail branch. Also, the fix failed for master branch.

Looked at diff and manually changed the code and new code solves the problem.

Now if I want to stick my patch to a ticket, should I build my patch against a 2-3 stable branch or master branch?

I believe the wizard is more closely related to the rails3 changes.

+2


a source to share


1 answer


Your best bet is to create a ticket at rails.lighthouseapp.com. Describe the problem and your fix in the ticket, and they will tell you which version of Rails to patch.



I recently created a patch for Rails and had to create a patch for master and 3.0.2. They are great at giving good reviews and praise, and they will tell you what to do since they still have to approve of them.

+1


a source







All Articles